-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA] [TS migration] Migrate 'NumberUtilsTest.js' test to TypeScript #36116
Merged
neil-marcellini
merged 1 commit into
Expensify:main
from
JKobrynski:migrateNumberUtilsTestToTypeScript
Feb 20, 2024
Merged
[No QA] [TS migration] Migrate 'NumberUtilsTest.js' test to TypeScript #36116
neil-marcellini
merged 1 commit into
Expensify:main
from
JKobrynski:migrateNumberUtilsTestToTypeScript
Feb 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JKobrynski
changed the title
[TS migration] Migrate 'NumberUtilsTest.js' test to TypeScript
[No QA] [TS migration] Migrate 'NumberUtilsTest.js' test to TypeScript
Feb 8, 2024
fabioh8010
approved these changes
Feb 8, 2024
filip-solecki
approved these changes
Feb 9, 2024
FYI @JKobrynski is OOO from Feb 12th to Feb 16th. |
melvin-bot
bot
requested review from
jjcoffee
and removed request for
a team
February 20, 2024 13:36
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
jjcoffee
approved these changes
Feb 20, 2024
We did not find an internal engineer to review this PR, trying to assign a random engineer to #25271 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
jjcoffee
approved these changes
Feb 20, 2024
neil-marcellini
approved these changes
Feb 20, 2024
🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.4.44-0 🚀
|
🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.44-13 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
$ #25271
PROPOSAL: N/A
Tests
npm run test tests/unit/NumberUtilsTest
Offline tests
N/A
QA Steps
N/A
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop